Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Git Submodule KaTeX and QuickJS? #2

Closed
awwong1 opened this issue Feb 1, 2020 · 2 comments
Closed

Suggestion: Git Submodule KaTeX and QuickJS? #2

awwong1 opened this issue Feb 1, 2020 · 2 comments

Comments

@awwong1
Copy link

awwong1 commented Feb 1, 2020

Hello again, would it be better to move the raw quickjs and katex files into separate repositories, referring to them through git submodules?
The QuickJS code used in this repo is already outdated (quickjs-2020-01-19.tar.xz).
Having these separated would make updating external dependencies simpler and keep this repository more modular.


Aside, I am very grateful for your work in implementing this feature. Using it locally right now with no issues.
I submitted a PR incorporating your extension in hugo. Admittedly, I am not very familiar with golang or C so if there are additional concerns, I am eager to listen.
gohugoio/hugo#6544
gohugoio/hugo#6842

@graemephi
Copy link
Owner

It's outdated, but so is the unofficial git repo linked to on quickjs's website :) Looking through the diff, there are no changes that affect this project.

Looking into it, go's tools don't support submodules. So, if you look at go-libsass then they have a Makefile that updates a submodule then copies the source into their tree. I can see that being worthwhile for complex dependencies, but both QuickJS and KaTeX are very simple as dependencies go, so I don't think it's all that worthwhile here. (I also have reservations about using git's more complex functionality but that feels like I'm just griping rather than offering a real reason).

I have a hugo fork on my profile with pretty much the exact changes you made. I didn't submit a PR cause its pretty heavyweight (requires cgo, doubles the executable size) and I'd like to add [ and ( support if it was going to have wider use. Although, I wasn't aware of #6544, I probably would have posted there if I was.

@awwong1 awwong1 closed this as completed Feb 1, 2020
@jasikpark
Copy link

Perhaps use godzilla or otto? It seems otto supports js sans CGO. And I think godzilla does as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants