Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No CMake install target when Crossguid is not the root project #63

Open
merwaaan opened this issue Jan 19, 2022 · 0 comments
Open

No CMake install target when Crossguid is not the root project #63

merwaaan opened this issue Jan 19, 2022 · 0 comments

Comments

@merwaaan
Copy link

Hi @graeme-hill

When using CMake, no INSTALL target is created if crossguid is not the root project.
We're in this situation because we use crossguid as a submodule of a parent CMake project (however we still need the INSTALL target).

This seems to be due to this line:

if (${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR})

Why is that condition required?
I've seen other projects adding an option to toggle installation on or off (eg. "CROSSGUID_INSTALL_ENABLED").
I could propose a PR with something similar if that's ok for you.

@merwaaan merwaaan changed the title No CMake install target whe nCrossguid is not the root project No CMake install target when Crossguid is not the root project Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant