Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated methods for Memoized annotation for plugin validation #16117

Closed
wolfs opened this issue Feb 11, 2021 · 0 comments
Closed

Ignore generated methods for Memoized annotation for plugin validation #16117

wolfs opened this issue Feb 11, 2021 · 0 comments
Assignees
Milestone

Comments

@wolfs
Copy link
Member

wolfs commented Feb 11, 2021

Our current work validation (ValidatePlugins task) finds a problem with this method in the Gradle docker plugin:

    @Internal
    @Memoized
    DockerClient getDockerClient() {
        ...
    }

Namely, it reports non-property method 'memoizedMethodPriv\$getDockerClient()' should not be annotated with: @Internal.

We should ignore these methods generated by Groovy either altogether or the method generated by the @Memoized annotation in particular.


cc: @gradle/execution

@wolfs wolfs added this to the 7.0 RC1 milestone Feb 11, 2021
@lptr lptr changed the title Ignore generated methods for Memoized for plugin validation Ignore generated methods for Memoized annotation for plugin validation Feb 23, 2021
@wolfs wolfs assigned wolfs and melix and unassigned wolfs Feb 23, 2021
@gradle gradle deleted a comment from melix Feb 23, 2021
@melix melix closed this as completed in 8c88551 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants