Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index layer of orange generating border #7466

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

daviirodrig
Copy link
Contributor

Description

This fixes #7368 and works fine from what I tested, I just don't know exactly all the implications of changing this z-index

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/71dcfa809ae29a94d20a0806f436ebd7bf333367/gradio-4.19.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@71dcfa809ae29a94d20a0806f436ebd7bf333367#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 17, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/statustracker patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix z-index layer of orange generating border

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair
Copy link
Collaborator

hannahblair commented Feb 21, 2024

Tested and works great! I don't think I see any issues with this. Thanks @daviirodrig 🙌

Kapture 2024-02-21 at 17 47 04

@abidlabs
Copy link
Member

Awesome I'll go ahead and merge this in. Thanks @daviirodrig @hannahblair!

@abidlabs abidlabs merged commit 98a2719 into gradio-app:main Feb 21, 2024
8 checks passed
@pngwn pngwn mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chatbot orange border makes dropdown into it flash and flicker and chat border is above dropdown info
4 participants