-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve responsiveness of gr.Audio()
controls
#6991
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/766f25ab18c1fa401296b17e779a3036ccc7729e/gradio-4.19.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@766f25ab18c1fa401296b17e779a3036ccc7729e#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
@hannahblair what is the status of this PR? Should we close it for now? |
gr.Audio()
in mobilegr.Audio()
controls
@pngwn thanks for reminding me of this - it's now good to for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, much nicer. Thanks for picking this back up @hannahblair!
Thanks @pngwn for reviewing! Let me get this in for the release |
Description
Adds some small improvements to the way the Controls component responds to smaller screens. Now, the extra controls like playback, volume etc. move to a second row below the playback controls for better fit, instead of all of the controls wrapping.
Note, this may change ever so slightly once the design team provide some more feedback about how we can improve it.
Before
After:
Note, this may change ever so slightly once the design team provide some more feedback about how we can improve it. For example, I don't love the visual imbalance of the controls caused by the width different on each side:
Closes: #7040
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh