Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve responsiveness of gr.Audio() controls #6991

Merged
merged 16 commits into from
Feb 16, 2024
Merged

Improve responsiveness of gr.Audio() controls #6991

merged 16 commits into from
Feb 16, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Jan 10, 2024

Description

Adds some small improvements to the way the Controls component responds to smaller screens. Now, the extra controls like playback, volume etc. move to a second row below the playback controls for better fit, instead of all of the controls wrapping.

Note, this may change ever so slightly once the design team provide some more feedback about how we can improve it.

Before
Kapture 2024-02-15 at 16 14 19

After:
Kapture 2024-02-15 at 16 10 43

Note, this may change ever so slightly once the design team provide some more feedback about how we can improve it. For example, I don't love the visual imbalance of the controls caused by the width different on each side:

Screenshot 2024-02-15 at 16 17 04

Closes: #7040

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 10, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/766f25ab18c1fa401296b17e779a3036ccc7729e/gradio-4.19.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@766f25ab18c1fa401296b17e779a3036ccc7729e#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 10, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/audio patch
@gradio/icons patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Improve responsiveness of gr.Audio() controls

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair marked this pull request as ready for review January 12, 2024 15:48
@hannahblair hannahblair marked this pull request as draft January 12, 2024 15:48
@pngwn
Copy link
Member

pngwn commented Feb 9, 2024

@hannahblair what is the status of this PR? Should we close it for now?

@hannahblair hannahblair changed the title Improve gr.Audio() in mobile Improve responsiveness of gr.Audio() controls Feb 15, 2024
@hannahblair hannahblair marked this pull request as ready for review February 15, 2024 15:21
@hannahblair
Copy link
Collaborator Author

@pngwn thanks for reminding me of this - it's now good to for review.

@hannahblair hannahblair requested a review from pngwn February 15, 2024 15:22
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, much nicer. Thanks for picking this back up @hannahblair!

@abidlabs
Copy link
Member

Thanks @pngwn for reviewing! Let me get this in for the release

@abidlabs abidlabs merged commit f191786 into main Feb 16, 2024
11 checks passed
@abidlabs abidlabs deleted the mobile-audio branch February 16, 2024 18:57
@pngwn pngwn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping of Audio component buttons with other components.
4 participants