Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS resets and specifiers to play nice with HF blog #4997

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

aliabid94
Copy link
Collaborator

footer img was inheriting margin, and h1 was inheriting color.

Fixes: #4963

@vercel
Copy link

vercel bot commented Jul 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gradio ✅ Ready (Inspect) Visit Preview Jul 22, 2023 0:14am

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 22, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/theme patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add CSS resets and specifiers to play nice with HF blog

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 22, 2023

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4997-all-demos


You can install the changes in this PR by running:

pip install https://gradio-builds.s3.amazonaws.com/ad62cd9238b39952abe4497682ef1c4af7503cc6/gradio-3.38.0-py3-none-any.whl

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for handling this @aliabid94!

@aliabid94 aliabid94 merged commit 41c8307 into main Jul 24, 2023
@aliabid94 aliabid94 deleted the css_specifiers_for_hf_blog branch July 24, 2023 23:35
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 24, 2023

🎉 Chromatic build completed!

There are 0 visual changes to review.
There are 0 failed tests to fix.

@pngwn pngwn mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedding modal sometimes contains vertically misaligned content
4 participants