diff --git a/superset/assets/src/dashboard/actions/datasources.js b/superset/assets/src/dashboard/actions/datasources.js index 45702d343ed5c..b5fd0a57cd7bc 100644 --- a/superset/assets/src/dashboard/actions/datasources.js +++ b/superset/assets/src/dashboard/actions/datasources.js @@ -28,7 +28,7 @@ export function fetchDatasourceMetadata(key) { return SupersetClient.get({ endpoint: `/superset/fetch_datasource_metadata?datasourceKey=${key}`, }) - .then(data => dispatch(data, key)) + .then(data => dispatch(setDatasource(data, key))) .catch(response => getClientErrorObject(response).then(({ error }) => dispatch(fetchDatasourceFailed(error, key)), diff --git a/superset/assets/src/explore/components/ExploreChartHeader.jsx b/superset/assets/src/explore/components/ExploreChartHeader.jsx index 3d6eb84f24c6e..b4cbc04d53c52 100644 --- a/superset/assets/src/explore/components/ExploreChartHeader.jsx +++ b/superset/assets/src/explore/components/ExploreChartHeader.jsx @@ -44,7 +44,8 @@ class ExploreChartHeader extends React.PureComponent { action: isNewSlice ? 'saveas' : 'overwrite', }; this.props.actions.saveSlice(this.props.form_data, params) - .then((data) => { + .then((json) => { + const { data } = json; if (isNewSlice) { this.props.actions.createNewSlice( data.can_add, data.can_download, data.can_overwrite, diff --git a/superset/assets/src/explore/components/ExploreViewContainer.jsx b/superset/assets/src/explore/components/ExploreViewContainer.jsx index 758081d0d974c..bded1877b65e1 100644 --- a/superset/assets/src/explore/components/ExploreViewContainer.jsx +++ b/superset/assets/src/explore/components/ExploreViewContainer.jsx @@ -15,6 +15,7 @@ import { chartPropShape } from '../../dashboard/util/propShapes'; import * as exploreActions from '../actions/exploreActions'; import * as saveModalActions from '../actions/saveModalActions'; import * as chartActions from '../../chart/chartAction'; +import { fetchDatasourceMetadata } from '../../dashboard/actions/datasources'; import { Logger, ActionLog, EXPLORE_EVENT_NAMES, LOG_ACTIONS_MOUNT_EXPLORER } from '../../logger'; const propTypes = { @@ -81,7 +82,7 @@ class ExploreViewContainer extends React.Component { (this.props.controls.datasource == null || nextProps.controls.datasource.value !== this.props.controls.datasource.value) ) { - this.props.actions.fetchDatasourceMetadata(nextProps.form_data.datasource, true); + fetchDatasourceMetadata(nextProps.form_data.datasource, true); } const changedControlKeys = this.findChangedControlKeys(this.props.controls, nextProps.controls);