From f0631f434dc4be742e88a00f4c72628985574aa8 Mon Sep 17 00:00:00 2001
From: kim <kim.phanhoang@epfl.ch>
Date: Thu, 4 Apr 2024 13:50:42 +0200
Subject: [PATCH] fix: fix shortcut navigation crash

---
 src/modules/navigation/ItemNavigation.tsx | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/modules/navigation/ItemNavigation.tsx b/src/modules/navigation/ItemNavigation.tsx
index 45917383..2b0f143c 100644
--- a/src/modules/navigation/ItemNavigation.tsx
+++ b/src/modules/navigation/ItemNavigation.tsx
@@ -1,3 +1,4 @@
+import { useEffect, useState } from 'react';
 import { useNavigate, useParams } from 'react-router-dom';
 
 import { Alert } from '@mui/material';
@@ -19,6 +20,11 @@ const { useItem, useDescendants, useItemsTags } = hooks;
 const DrawerNavigation = (): JSX.Element | null => {
   const rootId = useParams()[ROOT_ID_PATH];
   const navigate = useNavigate();
+  const [prevRootId, setPrevRootId] = useState(rootId);
+
+  useEffect(() => {
+    setPrevRootId(rootId);
+  }, [rootId]);
 
   const { t: translateMessage } = useMessagesTranslation();
 
@@ -30,6 +36,14 @@ const DrawerNavigation = (): JSX.Element | null => {
     navigate(buildContentPagePath({ rootId, itemId: newItemId }));
   };
 
+  // on root change, we need to destroy the tree
+  // since it keeps the same data on reload despite prop changes
+  // we cannot rely on isLoading because the data is taken from the cache
+  // bc of our query client optimization
+  if (prevRootId !== rootId) {
+    return <LoadingTree />;
+  }
+
   if (rootItem) {
     return (
       <MainMenu id={MAIN_MENU_ID}>