generated from graasp/graasp-repo
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate H5P apps display #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyphilia
requested changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright, I've left some minor comments! 📽️
codeofmochi
force-pushed
the
97-add-h5p
branch
6 times, most recently
from
August 16, 2022 12:14
d8bc19a
to
2debf03
Compare
codeofmochi
force-pushed
the
97-add-h5p
branch
2 times, most recently
from
August 16, 2022 13:22
23b3de3
to
73c4c7d
Compare
codeofmochi
force-pushed
the
97-add-h5p
branch
2 times, most recently
from
August 16, 2022 14:19
56d561b
to
4d711ab
Compare
codeofmochi
force-pushed
the
97-add-h5p
branch
from
August 16, 2022 14:37
4d711ab
to
c7cc784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #97
Add H5P display in Perform
TODO: merge dependencies first, then update package.json with non-branch URLs