Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Thumbnails from PackedItem #859

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Sep 24, 2024

This PR use the new PackedItem containing directly the thumbnails urls. I stopped using useItemThumbnailUrl hook.

@ReidyT ReidyT self-assigned this Sep 24, 2024
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 📗

@ReidyT ReidyT force-pushed the 1366-adds-thumbnails-in-packed-item branch from 422881f to 899aa8c Compare September 26, 2024 05:57
Copy link

sonarcloud bot commented Sep 26, 2024

@pyphilia pyphilia added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 6c5c1f3 Sep 27, 2024
4 checks passed
@ReidyT ReidyT deleted the 1366-adds-thumbnails-in-packed-item branch September 27, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants