Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add enroll page and handle logged in member #826

Merged
merged 8 commits into from
Oct 2, 2024
Merged

fix: add enroll page and handle logged in member #826

merged 8 commits into from
Oct 2, 2024

Conversation

spaenleh
Copy link
Member

No description provided.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh self-assigned this Jul 31, 2024
@pyphilia pyphilia marked this pull request as ready for review September 27, 2024 09:37
ReidyT
ReidyT requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, LGTM! I just let you some questions and suggestions 🎃

cypress/e2e/redirections.cy.ts Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/modules/pages/HomePage.tsx Outdated Show resolved Hide resolved
src/modules/pages/itemPage/EnrollContent.tsx Outdated Show resolved Hide resolved
src/modules/pages/itemPage/ItemPage.tsx Show resolved Hide resolved
src/modules/pages/itemPage/ItemPage.tsx Show resolved Hide resolved
src/modules/pages/itemPage/RequestAccessContent.tsx Outdated Show resolved Hide resolved
src/modules/pages/itemPage/RequestAccessContent.tsx Outdated Show resolved Hide resolved
src/modules/pages/itemPage/RequestAccessContent.tsx Outdated Show resolved Hide resolved
@pyphilia pyphilia requested a review from ReidyT October 1, 2024 13:25
ReidyT
ReidyT approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☔️

spaenleh
spaenleh commented Oct 2, 2024
View reviewed changes
Copy link
Member Author

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have left a few comments. Let me know.

cypress/e2e/membershipRequest.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/membershipRequest.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/pseudonimized.cy.ts Show resolved Hide resolved
cypress/e2e/pseudonimized.cy.ts Show resolved Hide resolved
cypress/fixtures/mockTypes.ts Outdated Show resolved Hide resolved
src/Root.tsx Outdated Show resolved Hide resolved
src/langs/constants.ts Show resolved Hide resolved
src/modules/item/Item.tsx Outdated Show resolved Hide resolved
src/modules/pages/HomePage.tsx Show resolved Hide resolved
@pyphilia pyphilia mentioned this pull request Oct 2, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit fc928a3 Oct 2, 2024
4 checks passed
@graasper graasper mentioned this pull request Sep 30, 2024
Merged
@spaenleh spaenleh deleted the enroll branch October 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@spaenleh spaenleh

Labels
v2.20.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaenleh @pyphilia @ReidyT