Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add shortcut previous button and map button #716

Merged
merged 13 commits into from
May 28, 2024
Merged

feat: add shortcut previous button and map button #716

merged 13 commits into from
May 28, 2024

Conversation

pyphilia
Copy link
Contributor

Screenshot 2024-05-22 at 11 56 02

@pyphilia pyphilia self-assigned this May 22, 2024
@pyphilia pyphilia marked this pull request as ready for review May 23, 2024 08:21
spaenleh
spaenleh requested changes May 24, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks and a layout issue. Let me know if you have questions. 🎈

cypress/e2e/shortcut.cy.ts Outdated Show resolved Hide resolved
cypress/e2e/shortcut.cy.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/config/selectors.ts Outdated Show resolved Hide resolved
src/langs/fr.json Outdated Show resolved Hide resolved
src/modules/item/Item.tsx Outdated Show resolved Hide resolved
src/modules/item/SectionHeader.tsx Outdated Show resolved Hide resolved
src/modules/navigationIsland/CustomButtons.tsx Show resolved Hide resolved
src/modules/item/FromShortcutButton.tsx Outdated Show resolved Hide resolved
src/modules/navigationIsland/GeolocationButton.tsx Outdated Show resolved Hide resolved
ReidyT
ReidyT reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have checked the code yet, but it is wanted to have the button in orange ? Should we use graasp's primary colour instead, so that the button integrates in better with the rest of the design?

@pyphilia pyphilia requested a review from spaenleh May 27, 2024 07:48
@pyphilia pyphilia linked an issue May 27, 2024 that may be closed by this pull request
Show that items have geolocation #639
Closed
spaenleh
spaenleh approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia pyphilia added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 4777616 May 28, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 28, 2024
Merged
@spaenleh spaenleh deleted the 714-map-from branch May 29, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT left review comments

@LinaYahya LinaYahya LinaYahya approved these changes

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
v2.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle from qs for shortcut origin Show map button Show that items have geolocation
4 participants
@pyphilia @spaenleh @LinaYahya @ReidyT