Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use async mutation for signout #608

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: use async mutation for signout #608

merged 1 commit into from
Apr 10, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Apr 10, 2024

This fixes an issue where the signout call is not awaitable if we do not use the mutateAsync.

The type of the callback needs to be updated in UI to match this.

@spaenleh spaenleh requested a review from ReidyT April 10, 2024 12:27
@spaenleh spaenleh self-assigned this Apr 10, 2024
@spaenleh spaenleh added the bug 🪲 Something isn't working label Apr 10, 2024
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@spaenleh spaenleh added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 8f59dcd Apr 10, 2024
4 checks passed
@spaenleh spaenleh deleted the fix-logout-no-await branch April 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working v2.10.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants