Migrate to vite.js and Typescript (fully typed) #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
added
build
spaenleh
force-pushed
the
ts-vite
branch
2 times, most recently
from
7b4896a
to
71a7456
Compare
pyphilia
requested changes
Mar 8, 2023
swouf
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Nice!
I guess that all files in .yarn/sdks/ are automatically generated so I didn't review them (I guess they can be trusted).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds vite as the bundler (instead of Create React App) and moves all files to typescript.
The code organisation is inspired by bullet proof react with the
modulesfolder and then repartition by "feature".Imports are absolute with path aliases:
@/points to/srccloses #133