Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make redirection screen more user friendly #485

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Oct 22, 2024

When the user comes from graasp.org the url query param is not set.
When the user goes to auth.graasp.org the backend does not provide a url to go to and the redirection screen does not know where to send the user.

To fix this issue:

  • change the redirection screen to make it less like "You have to wait, something will happen"
  • add a fixed fallback env value that goes to builder.graasp.org in each environnement for when there is nothing

Current Screen:

Screenshot 2024-10-22 at 08 57 30

New Screen:

Screenshot 2024-10-22 at 10 24 19

close #484

@spaenleh spaenleh self-assigned this Oct 22, 2024
@spaenleh spaenleh added the bug Something isn't working label Oct 22, 2024
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

src/langs/en.json Outdated Show resolved Hide resolved
cypress/e2e/SignIn.cy.ts Outdated Show resolved Hide resolved
cypress/support/server.ts Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 22, 2024

@spaenleh
Copy link
Member Author

@pyphilia I tried with the automatic redirection and I did not really like it. I think it is a bit nicer to have a welcome and click the button. This lets users know that they are logged in. Also this prevents any redirection loops that could be hard to debug if the url param is set to something that makes it look over itself.

@spaenleh spaenleh added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit a71ded4 Oct 22, 2024
4 checks passed
Copy link

sentry-io bot commented Oct 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotFoundError: The object can not be found here. insertBefore([native code]) View Issue

Did you find this useful? React with a 👍 or 👎

@spaenleh spaenleh deleted the 484-redirect-hangs branch October 28, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.7.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect without a url hangs on the redirection screen
2 participants