-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make redirection screen more user friendly #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Quality Gate passedIssues Measures |
@pyphilia I tried with the automatic redirection and I did not really like it. I think it is a bit nicer to have a welcome and click the button. This lets users know that they are logged in. Also this prevents any redirection loops that could be hard to debug if the url param is set to something that makes it look over itself. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
When the user comes from
graasp.org
theurl
query param is not set.When the user goes to
auth.graasp.org
the backend does not provide a url to go to and the redirection screen does not know where to send the user.To fix this issue:
builder.graasp.org
in each environnement for when there is nothingCurrent Screen:
New Screen:
close #484