Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not allow special characters in username #457

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: do not allow special characters in username #457

merged 1 commit into from
Oct 10, 2024

Conversation

MatveyK
Copy link
Contributor

@MatveyK MatveyK commented Sep 20, 2024

Relates to graasp/graasp#1406

@MatveyK MatveyK mentioned this pull request Sep 20, 2024
Merged
@MatveyK MatveyK force-pushed the 1311-special-chars-in-username branch from d8a810e to 7ac025a Compare September 24, 2024 12:17
pyphilia
pyphilia approved these changes Sep 25, 2024
View reviewed changes
src/langs/de.json Show resolved Hide resolved
src/utils/validation.ts Outdated Show resolved Hide resolved
@pyphilia pyphilia mentioned this pull request Sep 25, 2024
Merged
spaenleh
spaenleh approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Thank you for the update and the test.

ReidyT
ReidyT approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, LGTM! I just let you one question 🙋

src/langs/de.json Show resolved Hide resolved
@MatveyK MatveyK force-pushed the 1311-special-chars-in-username branch from 7ac025a to 42344b7 Compare October 8, 2024 08:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MatveyK MatveyK added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 8fa9316 Oct 10, 2024
3 checks passed
@graasper graasper mentioned this pull request Oct 10, 2024
Merged
@MatveyK MatveyK deleted the 1311-special-chars-in-username branch October 10, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia pyphilia approved these changes

Assignees

@MatveyK MatveyK

Labels
v2.7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MatveyK @pyphilia @spaenleh @ReidyT