-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reset password forms #414
Conversation
Quality Gate passedIssues Measures |
72cebc6
to
d098391
Compare
623c901
to
444b58e
Compare
444b58e
to
817b677
Compare
@pyphilia I can not assign you, but can you have a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice PR! It looks good to me, I just let you some questions and suggestions 🎃
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes, LGTM 🫕
Warning
DO NOT REVIEW YET !
This PR will be split into smaller ones to ease the review process
Request password reset
From the sign in page you can click on the small text below the password input:
The request password reset form
In it's validated state:
With validation errors (the button is disabled):
There is an error that is displayed if the server replies with an error (only possible if the captcha was not correct).
Reset password
Success:
Validations on the force of the password, matching both password and required inputs:
It is also possible to check the box to see both fields as text to debug any issues with not matching passwords.
Errors:
Missing token in url:
Server error, likely due to outdated token or password requirements not matched:
close #412