Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reset password forms #414

Merged
merged 27 commits into from
Oct 3, 2024
Merged

feat: add reset password forms #414

merged 27 commits into from
Oct 3, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented May 27, 2024

Warning

DO NOT REVIEW YET !
This PR will be split into smaller ones to ease the review process

Request password reset

From the sign in page you can click on the small text below the password input:
Screenshot 2024-10-01 at 18 38 28

The request password reset form
Screenshot 2024-10-01 at 18 36 51

In it's validated state:
Screenshot 2024-10-01 at 18 38 51

With validation errors (the button is disabled):
Screenshot 2024-10-01 at 18 39 05
Screenshot 2024-10-01 at 18 39 12

There is an error that is displayed if the server replies with an error (only possible if the captcha was not correct).

Reset password

Screenshot 2024-10-01 at 18 27 10

Success:
Screenshot 2024-10-01 at 18 28 16

Validations on the force of the password, matching both password and required inputs:
Screenshot 2024-10-01 at 18 27 42
Screenshot 2024-10-01 at 18 27 37
Screenshot 2024-10-01 at 18 27 31

It is also possible to check the box to see both fields as text to debug any issues with not matching passwords.

Errors:

Missing token in url:
Screenshot 2024-10-01 at 18 28 28

Server error, likely due to outdated token or password requirements not matched:
Screenshot 2024-10-01 at 18 28 00

close #412

@pyphilia pyphilia self-assigned this May 27, 2024
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh requested a review from ReidyT October 1, 2024 16:47
@spaenleh spaenleh self-assigned this Oct 1, 2024
@spaenleh spaenleh added the feature New feature or request label Oct 1, 2024
@spaenleh spaenleh marked this pull request as ready for review October 1, 2024 16:48
@spaenleh spaenleh removed the request for review from ReidyT October 1, 2024 16:52
@spaenleh spaenleh requested a review from ReidyT October 3, 2024 05:50
@spaenleh
Copy link
Member

spaenleh commented Oct 3, 2024

@pyphilia I can not assign you, but can you have a look ?

Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice PR! It looks good to me, I just let you some questions and suggestions 🎃

cypress/e2e/SignInPassword.cy.ts Show resolved Hide resolved
cypress/e2e/requestPasswordReset.cy.ts Show resolved Hide resolved
cypress/e2e/util.ts Show resolved Hide resolved
cypress/fixtures/members.ts Show resolved Hide resolved
src/components/common/styles.tsx Outdated Show resolved Hide resolved
src/components/layout/DialogHeader.tsx Outdated Show resolved Hide resolved
src/components/requestPasswordReset/ResetPassword.tsx Outdated Show resolved Hide resolved
src/components/requestPasswordReset/ResetPassword.tsx Outdated Show resolved Hide resolved
src/hooks/jwtToken.ts Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Oct 3, 2024

@spaenleh spaenleh requested a review from ReidyT October 3, 2024 09:39
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes, LGTM 🫕

@spaenleh spaenleh added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 4dd2baf Oct 3, 2024
3 checks passed
@spaenleh spaenleh deleted the 412-reset-password branch October 3, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement reset password interface
3 participants