Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update loading buttons, add error messages #363

Merged
merged 7 commits into from
Apr 15, 2024
Merged

fix: update loading buttons, add error messages #363

merged 7 commits into from
Apr 15, 2024

Conversation

spaenleh
Copy link
Member

In this PR:

  • update font
  • add a component that displays the query errors directly inside the form for better user experience on larger screens
  • add a nicer loading indicator when fetching invitations
  • use loading buttons for signIn and signUp to improve user experience while the calls are fetching
Screenshot 2024-04-12 at 20 26 46
Untitled.mov
Screen.Recording.2024-04-11.at.16.40.18.mov

@spaenleh spaenleh self-assigned this Apr 12, 2024
pyphilia
pyphilia approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements! Thanks for this PR.
My comment about "please" can be ignored, I'm just wondering if it's not a bit too much of politeness aha.

package.json Outdated Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
src/langs/en.json Show resolved Hide resolved
src/langs/en.json Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 8a14958 Apr 15, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
@spaenleh spaenleh deleted the update-font branch April 19, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

@mariembencheikh mariembencheikh Awaiting requested review from mariembencheikh

@ReidyT ReidyT Awaiting requested review from ReidyT

Assignees

@spaenleh spaenleh

Labels
improvement v2.3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @pyphilia