feat: fix styles, show logo, add footer content #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Looks good, to me, but maybe @MartinaVin would have a better idea on how to display the logo ?
refactor: show logo above title feat: add connection indicator (#342) * fix: wip * fix: add connection status * chore: update translation text Co-authored-by: Kim Lan Phan Hoang <[email protected]> * chore: update message Co-authored-by: Kim Lan Phan Hoang <[email protected]> * fix: make PR changes --------- Co-authored-by: Kim Lan Phan Hoang <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessarily the best place to show the logo. Maybe in small in the button with a friendlier message? " Enter the Graasp World"? 😆
close #268
close #147