Substitute <arg> with <buildArg> in Maven plugin doc. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
olyagpl
requested review from
d-kozak,
dnestoro and
melix
and removed request for
d-kozak and
lazar-mitrovic
olyagpl
commented
Dec 15, 2023
| @@ -133,7 +133,7 @@ Build Configuration]. It is also possible to customize the plugin within a | |||
| [source,xml] | |||
| ---- | |||
| <buildArgs> | |||
| <arg>--argument</arg> | |||
| <buildArg>--argument</buildArg> | |||
There was a problem hiding this comment.
Did it change too for specifying JVM arguments?
Currently we have:
<jvmArgs>
<arg>argument1</arg>
<arg>argument2</arg>
</jvmArgs>
There was a problem hiding this comment.
I don't think it ever changed, maybe it's Maven accepting both? @alvarosanchez wdyt?
There was a problem hiding this comment.
Yes, for tags mapped as collections (like buildArgs), the inner tags can use any name. The convention is to use the singular form of the plural tag name.
dnestoro
approved these changes
Dec 21, 2023
melix
approved these changes
Jan 22, 2024
alvarosanchez
approved these changes
Jan 22, 2024
| @@ -133,7 +133,7 @@ Build Configuration]. It is also possible to customize the plugin within a | |||
| [source,xml] | |||
| ---- | |||
| <buildArgs> | |||
| <arg>--argument</arg> | |||
| <buildArg>--argument</buildArg> | |||
There was a problem hiding this comment.
Yes, for tags mapped as collections (like buildArgs), the inner tags can use any name. The convention is to use the singular form of the plural tag name.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of https://corparch-core-srv.slack.com/archives/C77KND1RN/p1702494052179109