Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Windows builds. #524

Merged
merged 17 commits into from
Oct 18, 2023
Merged

Re-enable Windows builds. #524

merged 17 commits into from
Oct 18, 2023

Conversation

fniephaus
Copy link
Member

Fixes #520

@fniephaus fniephaus self-assigned this Oct 13, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 13, 2023
@dnestoro
Copy link
Collaborator

This is a good fix for the current state of workflows, but after I merge my PR we can remove this entire job and just add windows-latest as a variable in matrix

@fniephaus fniephaus force-pushed the fniephaus/windows branch 3 times, most recently from 9dbbd97 to 8db69bd Compare October 13, 2023 13:39
@fniephaus fniephaus force-pushed the fniephaus/windows branch 5 times, most recently from 8974153 to 5570c83 Compare October 17, 2023 16:33
@fniephaus fniephaus requested a review from melix October 18, 2023 08:57
@fniephaus fniephaus merged commit 3d31459 into master Oct 18, 2023
1 of 7 checks passed
@fniephaus fniephaus deleted the fniephaus/windows branch October 18, 2023 13:33
apereocas-bot referenced this pull request in apereo/cas Oct 24, 2023
@renovate
renovatebot(deps): update dependency org.graalvm.buildtools:native-gr…
051c39f 
…adle-plugin to v0.9.28

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.graalvm.buildtools:native-gradle-plugin](https://togithub.com/graalvm/native-build-tools) | `0.9.27` -> `0.9.28` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.graalvm.buildtools:native-gradle-plugin/0.9.28?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.graalvm.buildtools:native-gradle-plugin/0.9.28?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.graalvm.buildtools:native-gradle-plugin/0.9.27/0.9.28?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.graalvm.buildtools:native-gradle-plugin/0.9.27/0.9.28?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>graalvm/native-build-tools (org.graalvm.buildtools:native-gradle-plugin)</summary>

### [`v0.9.28`](https://togithub.com/graalvm/native-build-tools/releases/tag/0.9.28)

[Compare Source](https://togithub.com/graalvm/native-build-tools/compare/0.9.27...0.9.28)

#### What's Changed

-   Revert to previous version of `escapeArg()`. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [https://github.com/graalvm/native-build-tools/pull/515](https://togithub.com/graalvm/native-build-tools/pull/515)
-   Document test binary configuration by [@&#8203;abelsromero](https://togithub.com/abelsromero) in [https://github.com/graalvm/native-build-tools/pull/509](https://togithub.com/graalvm/native-build-tools/pull/509)
-   Fixes the problem that `org.junit.jupiter.api.condition.EnabledOnOs` cannot be used in NativeTest by [@&#8203;linghengqian](https://togithub.com/linghengqian) in [https://github.com/graalvm/native-build-tools/pull/504](https://togithub.com/graalvm/native-build-tools/pull/504)
-   Remove deprecated use of `getConvention` by [@&#8203;melix](https://togithub.com/melix) in [https://github.com/graalvm/native-build-tools/pull/522](https://togithub.com/graalvm/native-build-tools/pull/522)
-   Fix and improve major JDK version detection. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [https://github.com/graalvm/native-build-tools/pull/523](https://togithub.com/graalvm/native-build-tools/pull/523)
-   Bump com.h2database:h2 from 2.1.210 to 2.2.220 in /samples/metadata-repo-integration by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/graalvm/native-build-tools/pull/499](https://togithub.com/graalvm/native-build-tools/pull/499)
-   Fix toolchain documentation by [@&#8203;dnestoro](https://togithub.com/dnestoro) in [https://github.com/graalvm/native-build-tools/pull/525](https://togithub.com/graalvm/native-build-tools/pull/525)
-   Re-enable Windows builds. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [https://github.com/graalvm/native-build-tools/pull/524](https://togithub.com/graalvm/native-build-tools/pull/524)
-   Fix h2-related tests. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [https://github.com/graalvm/native-build-tools/pull/526](https://togithub.com/graalvm/native-build-tools/pull/526)
-   Make metadata repo test version-agnostic. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [https://github.com/graalvm/native-build-tools/pull/527](https://togithub.com/graalvm/native-build-tools/pull/527)
-   Make metadata repo Gradle test version-agnostic. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [https://github.com/graalvm/native-build-tools/pull/528](https://togithub.com/graalvm/native-build-tools/pull/528)

#### New Contributors

-   [@&#8203;dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/graalvm/native-build-tools/pull/499](https://togithub.com/graalvm/native-build-tools/pull/499)

**Full Changelog**: graalvm/native-build-tools@0.9.27...0.9.28

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apereo/cas).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnestoro dnestoro dnestoro approved these changes

@melix melix melix approved these changes

@olpaw olpaw Awaiting requested review from olpaw

Assignees

@fniephaus fniephaus

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Windows Tests in GitHub Actions
3 participants
@fniephaus @dnestoro @melix