-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add navbarElement and weekdayElement props #179
Conversation
Hi @boatkorachal thanks for the help and congrats for your first PR 🎊 To maintain backward compatibility, we should not remove these |
(You should rebase your branch with master to fix these conflicts) |
@@ -43,8 +43,8 @@ export default class DayPicker extends Component { | |||
onCaptionClick: PropTypes.func, | |||
|
|||
renderDay: PropTypes.func, | |||
weekdayComponent: PropTypes.func, | |||
navbarComponent: PropTypes.func, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep those lat two lines. I'll add a PropType to deprecate them. Same for the other changes :)
ewww i just did the rebase and force push. hope that i haven't done anything wrong :) |
Yay thanks! Could you even test that the rendered component is actually the navbarElement? 🙏 |
Isn't it checked at proptypes? or should I import react-addons-test-utils and change to something like this if ( TestUtils.isElement(navbarElement) ) {
return React.cloneElement(navbarElement, props)
} |
The test coverage has been decreased, this is because we didn't include a test to check if passing a Actually, even |
I have just update tests. Is it ok? (I have to admit that this is the first time i write the tests too haha) |
oh sorry i forgot to run lint. i'm gonna fix it now. |
Looks good! Thanks a lot! |
from #177