-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-a11y DayPicker warning #386
Comments
Thanks for the report! Which version of react-a11y are you using? |
I'm using react-a11y v0.3.3 which seems to be the latest. |
See http://rawgit.com/w3c/aria/master/aria/aria.html#gridcell: “A gridcell may be focusable, editable, and selectable.” (#386)
I've found the reason of this warning: when the days outside the current month are not shown, we are still adding
which is clearly not the case – removing the |
(the fix will be published to the upcoming release) |
Great, thanks for the quick turn around, really appreciate your work on this component. It's fantastic and I use it in multiple projects (not all needing this level of accessibility) :). |
Thanks @reintroducing for the nice words! The change has been published in v6.0.0 (changelog) 🎉 |
I'm working on a project where accessibility is a requirement and I just integrated DayPicker into the fold. I'm using react-a11y to warn me of any possible issues I may run into/omit to make sure I am not forgetting accessibility when developing my components. I'm seeing this pop up now:
I can't for the life of me figure out where its coming from or how to resolve it. I'm not using any fancy implementation of DayPicker, just pretty standard stuff:
Any help would be greatly appreciated.
The text was updated successfully, but these errors were encountered: