-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spread attributes to container. #123
Conversation
This would allow us to pass event listeners and all sort of things. See gpbl#122.
Thanks @srph, also for adding a test 🙌 Yes, I believe that
If you prefer, I can push these changes. For the docs, don't worry, I'll update them as the PR is merged. |
I made some updates. I think I'm quite lost (primarily with the tests) -- but I can revert stuff back to the original (before these new commits today)). Or I can just clean up the mess first, and ping you here in GH in a few hours. (writing code during Fridays is bad; I never learn haha) For If it looks good, I can squash the commits first, though. Edit: I wrote some test cases for the new behavior of |
Looks fine to me thanks! (Don't worry about the decreased coverage, i'll check it out) |
Let me know if you need helps with the test... I know it's a bit too messy there, I should separate them in different files. |
Hmm, anything I missed out? By the way, how about the |
Nothing, it's perfect! 👍 Going to cut a new release soon 🚀 |
Alright, I hope I didn't break anything crosses fingers. Thanks for your work! |
This would allow us to pass event listeners and all sort
of things. Closes #122.
Do not merge yet, needs documentation.
edit: oops, right before that — should we remove the explicit
style
props?