Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLDecoder #1441

Closed
wants to merge 3 commits into from
Closed

URLDecoder #1441

wants to merge 3 commits into from

Conversation

wushuo894
Copy link

Fixed an issue where image files in epub could not be displayed normally when the file name was Chinese

@wushuo894
Copy link
Author

Xnip2024-03-11_13-28-27

@wushuo894
Copy link
Author

Xnip2024-03-11_13-33-27

@wushuo894
Copy link
Author

Xnip2024-03-11_13-28-27

Some of the Mimetypes fetched by epub contain \r\n

@wushuo894
Copy link
Author

Xnip2024-03-11_13-33-27

Chinese and url encoding conversion problems

Xnip2024-03-11_13-33-27

Chinese and url encoding conversion problems

@gotson
Copy link
Owner

gotson commented Mar 11, 2024

can you please create an issue first, and provide the file that causes the issue?

@wushuo894
Copy link
Author

can you please create an issue first, and provide the file that causes the issue?

ok

@gotson
Copy link
Owner

gotson commented Mar 11, 2024

Xnip2024-03-11_13-28-27

this seems to indicate that the file is incorrect, according to https://www.w3.org/TR/epub/#sec-zip-container-mime

The mimetype file MUST NOT contain any leading or trailing padding or white space.

@wushuo894
Copy link
Author

Xnip2024-03-11_13-28-27

this seems to indicate that the file is incorrect, according to https://www.w3.org/TR/epub/#sec-zip-container-mime

The mimetype file MUST NOT contain any leading or trailing padding or white space.

This is true, but the epub can be opened in apple reader
Xnip2024-03-11_14-41-25

@wushuo894
Copy link
Author

Xnip2024-03-11_13-28-27

this seems to indicate that the file is incorrect, according to https://www.w3.org/TR/epub/#sec-zip-container-mime

The mimetype file MUST NOT contain any leading or trailing padding or white space.

This is true, but the epub can be opened in apple reader Xnip2024-03-11_14-41-25

Xnip2024-03-11_14-43-32

@gotson
Copy link
Owner

gotson commented Mar 12, 2024

Xnip2024-03-11_13-28-27

this seems to indicate that the file is incorrect, according to w3.org/TR/epub/#sec-zip-container-mime

The mimetype file MUST NOT contain any leading or trailing padding or white space.

This is true, but the epub can be opened in apple reader Xnip2024-03-11_14-41-25

the file you provided in #1442 is correctly detected as EPUB in Komga

@gotson gotson closed this in f8e40ce Mar 12, 2024
@wushuo894
Copy link
Author

Xnip2024-03-11_13-28-27

this seems to indicate that the file is incorrect, according to w3.org/TR/epub/#sec-zip-container-mime

The mimetype file MUST NOT contain any leading or trailing padding or white space.

This is true, but the epub can be opened in apple reader Xnip2024-03-11_14-41-25

the file you provided in #1442 is correctly detected as EPUB in Komga

人间系列01 零崎双識的人間試験.epub.zip

This is the file that failed to identify

@gotson
Copy link
Owner

gotson commented Mar 12, 2024

Xnip2024-03-11_13-28-27

this seems to indicate that the file is incorrect, according to w3.org/TR/epub/#sec-zip-container-mime

The mimetype file MUST NOT contain any leading or trailing padding or white space.

This is true, but the epub can be opened in apple reader Xnip2024-03-11_14-41-25

the file you provided in #1442 is correctly detected as EPUB in Komga

人间系列01 零崎双識的人間試験.epub.zip

This is the file that failed to identify

thanks, you should probably have started by providing the file

gotson added a commit that referenced this pull request Mar 12, 2024
Copy link
Contributor

🎉 This issue has been resolved in 1.10.4 (Release Notes)

@wushuo894 wushuo894 deleted the fix-url branch March 23, 2024 12:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants