-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot search for publishers with commas in name #1169
Comments
This is a tricky case. Filters are passed to the backend via query parameters. Query parameters can be passed on different ways in case there are multiple values, either a single parameter with comma separated values Spring is smart enough to handle various cases, however when you pass a single value that is comma separated, it throws the logic off. If you were to filter on that publisher and another one, it works as expected. For reference I found other people have the same issue spring-projects/spring-framework#23820 and spring-projects/spring-framework#29411 Seems like it's a Spring problem which won't get fixed, I would need to test some of the proposed workarounds. |
I've spent a decent amount of time today trying to fix this, and unfortunately there is no good solution for the moment. Changing the logic used for splitting parameters with the The best course of action would be to move from a GET request with request parameters to a search object in the body of the request. |
@gotson Adding below method inside controlled fixed this issue.
|
it tried this but it breaks other stuff |
Steps to reproduce
Expected behavior
Komga should find series from that publisher
Actual behavior
Komga can't find anything
Logs
No response
Komga version
1.2.1
Operating system
Arch Linux
Other details
This metadata was imported via AnisearchKomga, in case you're normally not supposed to be able to even enter commas, and this tool just happened to break everything.
Acknowledgements
The text was updated successfully, but these errors were encountered: