Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Show loading indicator when loading messages instead of "No messages" #658

Closed
MexHigh opened this issue Jun 2, 2024 · 3 comments · Fixed by #660
Closed

[UI] Show loading indicator when loading messages instead of "No messages" #658

MexHigh opened this issue Jun 2, 2024 · 3 comments · Fixed by #660
Labels
a:feature New feature or request

Comments

@MexHigh
Copy link
Contributor

MexHigh commented Jun 2, 2024

Is your feature request related to a problem? Please describe.
I have around 10 applications in Gotify, all of them receiving messages regularly. When I want to check them in the UI, I usually do this app by app and not via the "All messages" tab. When switching between application tabs, there is a short amount of time, where the messages are being fetched and the messages panel is empty saying "No messages".

If I want to quickly take a look at all application tabs, sometimes I'm not waiting long enough for the messages to come in and then assume that there are none, because there was no loading indicator.

Describe the solution you'd like
There should be some kind of loading indicator (e.g. a spinner) when opening an application tab the first time. This should only introduce changes in the ui, not the backend code.

Describe alternatives you've considered
None.

Additional context
Not required, I think.

@MexHigh MexHigh added the a:feature New feature or request label Jun 2, 2024
@jmattheis
Copy link
Member

Sounds like a useful addition 👍

@MexHigh
Copy link
Contributor Author

MexHigh commented Jun 5, 2024

If I find some time, I'll try to implement this next week myself and open a PR

@MexHigh
Copy link
Contributor Author

MexHigh commented Jun 18, 2024

So, after a wrongly pushed branch it should work now, feel free to review #660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature New feature or request
2 participants