Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK 34 Play Store Rejected without video of FOREGROUND_SERVICE_DATA_SYNC functionality #660

Open
baggednismo opened this issue Apr 24, 2024 · 13 comments

Comments

@baggednismo
Copy link

Describe the bug
The library has been fully functional and setup as documented. Has been working in production for months now. Targeted the latest SDK 34 when building for release. After uploading to google play console it throws an error You must let us know whether your app uses any Foreground Service permissions.

Looking through the manifest merge logs I found this
ADDED from [net.gotev:uploadservice:4.9.2] /Users/{user}/.gradle/caches/transforms-3/79699670084e687319315e25462d08d3/transformed/jetified-uploadservice-4.9.2/AndroidManifest.xml:8:22-74 uses-permission#android.permission.FOREGROUND_SERVICE_DATA_SYNC

Using this library now requires videos to be taken of the upload process in order to release it.

To Reproduce

  1. Set target / compile SDK to 34
  2. Upload to Google Play console as a new release.

Screenshots
Screenshot 2024-04-24 at 11 34 54 AM
Screenshot 2024-04-24 at 11 35 24 AM

@gotev
Copy link
Owner

gotev commented Apr 24, 2024

Thank you, useful to be known!

@trix0
Copy link

trix0 commented May 2, 2024

@baggednismo I am currently in a process to upgrade our apps for SDK 34 and originally came looking if DATA_SYNC will be good enough for this.

Did your app manage to get through the process after you uploaded the video?

@baggednismo
Copy link
Author

@trix0 I didn't want to take the chance, I had a critical project that needed to move to production. I removed the library and switched to workmanager.

@swizes
Copy link

swizes commented May 7, 2024

we are also actively using this library and with provided video of upload feature our app has been approved.

@sublime392
Copy link

sublime392 commented Jul 10, 2024

edit: I see this has been addressed, and it doesn't look super good for this lib: #610 (comment)

Are there any plans to change this to use workmanager?

Using FOREGROUND_SERVICE_DATA_SYNC is not allowed unless the user is not directly interacting with the app during the upload. I don't think typical uses will qualify, hence the video requirement because Google doesn't think most use cases will qualify either.

Even if it gets through once, it would be a risk because a year from now you might be trying to patch a bug and then get rejected because the new reviewer does not agree with how FOREGROUND_SERVICE_DATA_SYNC is being used.

@gotev
Copy link
Owner

gotev commented Jul 10, 2024

@sublime392 in #610 I still haven't got any other thought about my reasoning, nor contributors wanting to help. Currently I don't have time for a rewrite. Re-opened it so it gains some visibility.

@linean
Copy link

linean commented Aug 7, 2024

Despite providing an explanatory video, Google has rejected my app update saying:

Specifically, the declared use case(s) can be interrupted or deferred by the system without creating a negative user experience. Your app is using foreground service to Data Sync - Other when it is not required to do so.

It seems the only solution is to migrate to a different lib 😞

@gotev
Copy link
Owner

gotev commented Aug 7, 2024

@linean if you're using only the bundled-in Binary and Multipart upload protocols of the lib, you can make a point that they do not support resume, so you have to start the uploads over in case of any interruptions, leading to poor UX and higher network and battery usage. This is one of the major points in favor of keeping the service architecture and also common knowledge, specified in the respective RFCs and also documented in the wiki: https://github.com/gotev/android-upload-service/wiki/4.x-Usage#http-multipartform-data-upload--rfc2388 but it's better to let Google reviewers know, as they may assume you're using a resumable upload protocol.

@linean
Copy link

linean commented Aug 7, 2024

Thanks, that's a great suggestion! I'll consider this option.

@gotev
Copy link
Owner

gotev commented Aug 7, 2024

@linean I don't know the specifics of your use case, but for anyone reading this, if your app is made for field operations or you need fast and instant uploads, which are critical for your use case, let Google reviewers know, together with the specifics I mentioned about binary and multipart upload protocols in my previous comment.

@senryakuka
Copy link

Hi last month i'm updating my app to comply with the play store request and this problem also occured to me, i make a video where the the library is used and google approved it

@derwaldgeist
Copy link

Hi, I ran into the same issue when upgrading my app for Android 34. I hope I will get through the verification process.

Can you maybe provide an explanation why exactly this permission is required?

@gotev
Copy link
Owner

gotev commented Nov 11, 2024

@derwaldgeist

Can you maybe provide an explanation why exactly this permission is required?

it's mandatory for apps and libs targeting Android 14: https://developer.android.com/about/versions/14/changes/fgs-types-required?hl=en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants