Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fs.WithSymlink lack of symmetry #192

Open
dnephin opened this issue Feb 21, 2020 · 0 comments
Open

Fix fs.WithSymlink lack of symmetry #192

dnephin opened this issue Feb 21, 2020 · 0 comments

Comments

@dnephin
Copy link
Member

dnephin commented Feb 21, 2020

fs.WithSymlink, when used with a Dir or File creates a link with an absolute path, when used with a Manifest it expects a relative path.

I think both cases could be useful, but having different behaviour in the same function is a problem. I think this function can be deprecated and replaced with: fs.WithRelativeSymlink and fs.WithAbsoluteSymlink which have consistent behaviour for all types of Path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant