Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDependencies named "0", "1", etc. added #16

Closed
CodingItWrong opened this issue Jan 3, 2019 · 1 comment
Closed

devDependencies named "0", "1", etc. added #16

CodingItWrong opened this issue Jan 3, 2019 · 1 comment

Comments

@CodingItWrong
Copy link

CodingItWrong commented Jan 3, 2019

In 0.0.5 if I choose Manual then add addons, I get package.json entries named "0", "1", etc. instead of the names of the addons.

To reproduce, choose Manual, then add addon ember-decorators, then leave all remaining options as-is. This is the package.json I get generated in response:

{
  "name": "ecc-test-5",
  "version": "0.0.0",
  "private": true,
  "description": "Small description for ecc-test-5 goes here",
  "repository": "",
  "license": "MIT",
  "author": "",
  "directories": {
    "doc": "doc",
    "test": "tests"
  },
  "scripts": {
    "build": "ember build",
    "lint:hbs": "ember-template-lint .",
    "lint:js": "eslint .",
    "start": "ember serve",
    "test": "ember test"
  },
  "devDependencies": {
    "0": "^0.0.0",
    "@ember/optional-features": "^0.6.3",
    "broccoli-asset-rev": "^2.7.0",
    "ember-ajax": "^3.1.0",
    "ember-cli": "~3.6.0",
    "ember-cli-app-version": "^3.2.0",
    "ember-cli-babel": "^7.1.2",
    "ember-cli-dependency-checker": "^3.0.0",
    "ember-cli-eslint": "^4.2.3",
    "ember-cli-htmlbars": "^3.0.0",
    "ember-cli-htmlbars-inline-precompile": "^1.0.3",
    "ember-cli-inject-live-reload": "^1.8.2",
    "ember-cli-sri": "^2.1.1",
    "ember-cli-template-lint": "^1.0.0-beta.1",
    "ember-cli-uglify": "^2.1.0",
    "ember-data": "~3.6.0",
    "ember-export-application-global": "^2.0.0",
    "ember-load-initializers": "^1.1.0",
    "ember-maybe-import-regenerator": "^0.1.6",
    "ember-qunit": "^3.4.1",
    "ember-resolver": "^5.0.1",
    "ember-source": "~3.6.0",
    "eslint-plugin-ember": "^5.2.0",
    "loader.js": "^4.7.0",
    "qunit-dom": "^0.8.0"
  },
  "engines": {
    "node": "6.* || 8.* || >= 10.*"
  }
}

Note the first devDependency is "0"

It seems like the "0" entry is added instead of the ember-decorators entry, and something is making the version calculation not work correctly. Other addons I add sometimes result in a version number added though.

@gossi gossi closed this as completed in 348c552 Jan 3, 2019
@gossi
Copy link
Owner

gossi commented Jan 3, 2019

Fixed. Released 0.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants