RangeError - Maximum call stack size exceeded. #15

alexanderwallin · 2021-03-18T16:54:13Z

Hi there,

I liked the API design of this library and decided to use it together with react-native-modalize. It worked well locally, but in distribution builds the below error caused crashes on both iOS and Android.

I switched to another library and unfortunately can't put time into creating a bare minimum reproducible case. But I thought I'd share it!

RangeError
Maximum call stack size exceeded.

    node_modules/immer/dist/immer.esm.js:1:712 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588 
    node_modules/immer/dist/immer.esm.js:1:782 
    [native code] forEach
    node_modules/immer/dist/immer.esm.js:1:745 i
    node_modules/immer/dist/immer.esm.js:1:2562 M
    node_modules/immer/dist/immer.esm.js:1:3055 A
    node_modules/immer/dist/immer.esm.js:1:2588

The text was updated successfully, but these errors were encountered:

gorhom · 2021-03-19T21:54:16Z

hi @alexanderwallin, could you provide a reproducible sample code so i could investigate it.

alexanderwallin · 2021-03-25T08:38:42Z

@gorhom Sorry, like I said in the description, I unfortunately don't have the time.

beqramo · 2021-03-25T12:44:12Z

@gorhom I have the same problem, and reproduction steps are simple, take any example and place Portalhost in the parent component of Portal and you will see the problem. I agree @alexanderwallin that it is only in production.

image:

gorhom · 2021-03-25T13:38:00Z

@beqramo thanks for adding more context to this bug, i will look into it

beqramo · 2021-03-30T07:10:32Z

@gorhom by the way, I'm using it with https://github.com/dabakovich/react-native-controlled-mentions#readme
maybe it will give you some clue, and maybe the problem is when using it with a library.

mobily · 2021-05-10T15:37:23Z

I was struggling with this error as well, and I was able to fix it only by completely removing immer and patching the lib with patch-package.

@gorhom I will do some testing once again, but I think that the reducer logic isn't very complex, and immer looks like a redundant dependency, if you would like to remove it, I can create a PR :)

alexanderwallin · 2021-05-10T15:53:00Z

No idea if this causes the issue, but the return here looks a little suspicious, I don't think you are supposed to return the draft.
https://github.com/gorhom/react-native-portal/blob/master/src/state/reducer.ts#L132

beqramo · 2021-05-10T15:55:14Z

indeed I was able to resolve this issue by wrapping my components in useMemo. there was rerender problem and so for me, that was a solution.

mobily · 2021-05-10T16:27:59Z

@alexanderwallin I've just tested it, and it still doesn't work, the same error occurs 😢

@beqramo cool! nevertheless, I think it should work either with or without memo

gorhom · 2021-05-11T08:09:23Z

i will look into this today, sorry for the late response

gorhom · 2021-05-11T21:13:51Z

@mobily did removing Immer solve the problem ?

mobily · 2021-05-12T07:14:14Z

@gorhom yup, I have been looking for the root of this issue for a few hours and couldn't find anything, and removing Immer did solve the issue eventually

gorhom · 2021-05-12T07:28:02Z

@mobily alright! one more thing, could you provide a reproducible sample code ?

mobily · 2021-05-12T07:29:54Z

@gorhom sure, I will create a repo later today ;)

timbastin · 2021-05-18T16:01:43Z

I am having the same issue. Is there any fix for this yet?

gorhom · 2021-05-19T08:27:52Z

@mobily any luck with the repo ?

mobily · 2021-05-20T09:07:02Z

@gorhom 👋 no luck :( I have created a fresh RN project with basic components/hooks/helpers that I use in my commercial project, and it works with no error, the app doesn't crash in the release mode… not sure why, I'm looking for a reason

jordoh · 2021-05-25T22:08:14Z

I'm seeing the same exception using react-native-portal via react-native-bottom-sheet - it only happens in production, when a button on one BottomSheetModal triggers a present on a second BottomSheetModal. I've spent some time trying to reproduce in expo (with expo in production mode) without any success.

alexco2 · 2021-05-28T17:52:59Z

I have the same error in react-native-bottom-sheet. It happens when I close the screen that holds the bottomSheetModalRef while the BottomSheetModal is still open (for example with the hardware back button). In that case the BottomSheetModal closes after the screen is closed. If I try to open the BottomSheetModal again after opening the screen, the app crashes with the error "RangeError: Maximum call stack size exceeded" error.
I tried to close the BottomSheetModal activley when the screen unmounts with useEffect, which did not solve the problem. If I listen for the Backhandler and close the BottomSheetModal as soon as the Back Button is pressed, the error just occurs, if I fully extended the BottomSheetModal first. Then the BottomSheetModal is closed when pressing the Back Button, but can not be opened again. After closing and opening the screen that holds the bottomSheetModalRef, the app crashes when I try to open the BottomSheetModal again. In development, I get the error TypeError: Cannot read property 'minimize' of null, js engine: hermes (picture). The BottomSheetModalProvider is on the top level on my App btw.
I hope this description somehow helps.

gorhom · 2021-06-10T21:04:27Z

Hi everyone , could anyone try to reproduce it on v1.0.6, thanks ?

egadstar · 2021-06-29T20:39:25Z

I had seen this error before, but no more. Thanks.

mobily · 2021-07-12T12:11:54Z

@gorhom works fine! thanks for fixing this issue ❤️

gorhom · 2021-07-12T12:13:02Z

@mobily thanks for testing it 👏

dburdan · 2021-07-16T22:53:42Z

We're also getting Maximum call stack size exceeded when dismissing one BottomSheetModal and immediately opening another. Using @gorhom/portal: 1.0.7 & @gorhom/bottom-sheet": 4.0.0-alpha.18. Only happens in release mode, and haven't been able to find a solution.

gorhom · 2021-07-17T15:51:52Z

@dburdan could you please provide more info ( env, os, rn version ) or a reproducible sample ? I appreciate it

dburdan · 2021-07-18T17:54:51Z

@gorhom We are running react-native: 0.64.2. Crash exists across iOS and Android, and every device we've tested.

It's been difficult to trace since everything works great when in debug mode. The crash only appears after building to device or to simulator in release mode. Is there any other information I could share that would be helpful? If I get some time this week, I'll try to build a reproducible example.

UrbanChrisy · 2021-08-18T10:26:06Z

I was using react context provider inside the Portal component, and I was getting this issue in a release build only like above. When I moved the context provider to the outside of the PortalHost. Because I'm using the portal host at a different layer than the root host. Then I no longer had this issue. I don't know what would cause this, but ill try to create a reproducible expo demo tomorrow. Ill update where I get to.

UrbanChrisy · 2021-08-20T03:38:34Z

Unable to reproduce as of yet. Ive spent wayyy too long on this already sorry guys unable to give a demo. I managed to fix my issue by moving the context provider to wrap the portal host inside the nested child portal

lucianojsjr · 2021-08-31T03:24:32Z

@gorhom Are there some news about this problem? I'm getting the same error and I'm using [email protected].

SCasarotto · 2021-09-13T14:02:47Z

I am also seeing this issue but it only seems to appear once the app is in release mode or built.

egadstar · 2021-09-20T02:38:20Z

Could this be the source based on the original stacktrace? immerjs/immer#832

immerjs/immer#673

egadstar · 2021-09-20T17:59:08Z

I ended up forking and refactoring immer from the project; my production builds are no longer crashing with the RangeError, so feel pretty certain that the issue is related to a bug within immer.

gorhom · 2021-09-20T18:57:45Z

@egadstar would you mind submitting a pr :)

egadstar · 2021-09-20T19:17:25Z

Yea, no problem. Because I removed immer, I didn't know if you wanted to move that direction. I'll get it submitted, and you can review it.

egadstar · 2021-09-20T20:06:26Z

I did a poor job reading through this thread; didn't realize that @mobily had already zeroed in on immer.

gorhom · 2021-09-21T07:39:20Z

this should be fixed with v1.0.9 , thanks to @egadstar PR 👏

gorhom self-assigned this Mar 19, 2021

alexco2 mentioned this issue May 28, 2021

BottomSheetModal crashes app when closed with Back Button gorhom/react-native-bottom-sheet#465

Closed

egadstar mentioned this issue Sep 20, 2021

refactor: removing immer to fix max call stack error with production … #20

Merged

gorhom closed this as completed in #20 Sep 21, 2021

RangeError - Maximum call stack size exceeded. #15

RangeError - Maximum call stack size exceeded. #15

Comments

alexanderwallin commented Mar 18, 2021 • edited Loading

gorhom commented Mar 19, 2021

alexanderwallin commented Mar 25, 2021

beqramo commented Mar 25, 2021 • edited Loading

gorhom commented Mar 25, 2021

beqramo commented Mar 30, 2021

mobily commented May 10, 2021

alexanderwallin commented May 10, 2021

beqramo commented May 10, 2021

mobily commented May 10, 2021

gorhom commented May 11, 2021

gorhom commented May 11, 2021

mobily commented May 12, 2021

gorhom commented May 12, 2021

mobily commented May 12, 2021

timbastin commented May 18, 2021

gorhom commented May 19, 2021

mobily commented May 20, 2021

jordoh commented May 25, 2021

alexco2 commented May 28, 2021 • edited Loading

gorhom commented Jun 10, 2021

egadstar commented Jun 29, 2021

mobily commented Jul 12, 2021

gorhom commented Jul 12, 2021

dburdan commented Jul 16, 2021

gorhom commented Jul 17, 2021

dburdan commented Jul 18, 2021

UrbanChrisy commented Aug 18, 2021

UrbanChrisy commented Aug 20, 2021 • edited Loading

lucianojsjr commented Aug 31, 2021

SCasarotto commented Sep 13, 2021

egadstar commented Sep 20, 2021 • edited Loading

egadstar commented Sep 20, 2021

gorhom commented Sep 20, 2021

egadstar commented Sep 20, 2021

egadstar commented Sep 20, 2021

gorhom commented Sep 21, 2021

alexanderwallin commented Mar 18, 2021 •

edited

Loading

beqramo commented Mar 25, 2021 •

edited

Loading

alexco2 commented May 28, 2021 •

edited

Loading

UrbanChrisy commented Aug 20, 2021 •

edited

Loading

egadstar commented Sep 20, 2021 •

edited

Loading