Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A "no-popups: * true" rule will block new tabs opened from "chrome://extensions/" #1538

Closed
gorhill opened this issue Apr 5, 2016 · 1 comment

Comments

@gorhill
Copy link
Owner

gorhill commented Apr 5, 2016

Describe the issue

As first reported at http://www.wilderssecurity.com/threads/ublock-a-lean-and-fast-blocker.365273/page-77#post-2578260:

When i turn the logger on and click the Get more extensions -link, I will get this and only this:

13:20:37 no-popups: * true -- popup https://chrome.google.com/webstore/category/extensions?hl=en-US

One or more specific URLs where the issue occurs

chrome://extensions/

Steps for anyone to reproduce the issue

  1. Have chrome-scheme in Whitelist.
  2. Have no-popups: * true in My rules.
  3. Paste chrome://extensions/ in the address bar of a new tab.
  4. Scroll to the bottom, click the link "Get more extensions".
  5. Result: the new tab is automatically closed.

The new tab should not be affected by the no-popups: * true rule, as the new tab was opened from clicking a link in a whitelisted page.

Your settings

  • Browser/version: Chromium 49.
  • uBlock Origin version: 1.6.8.
Your filter lists

Default filter lists.

@gorhill gorhill closed this as completed in 13f746a Apr 5, 2016
@gorhill
Copy link
Owner Author

gorhill commented Apr 5, 2016

uBO can't inject its content scripts into chrome:// (and likes) pages, so it is unable to detect that the new tab is legitimately opened by the user. Furthermore, uBO disregarded the whitelist status of URLs with non-http/non-https scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant