Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources blocked through a redirection URL are not collapsed #1013

Closed
gorhill opened this issue Dec 5, 2015 · 3 comments
Closed

Resources blocked through a redirection URL are not collapsed #1013

gorhill opened this issue Dec 5, 2015 · 3 comments

Comments

@gorhill
Copy link
Owner

gorhill commented Dec 5, 2015

Repro steps:

The src property for the embedded iframe is /ajax/inset/iframe?id=youtube-video-KqpHTFJO4mE&start=0, which means that the iframe appears to be 1st-party.

However there is redirection server-side which causes the effective URL for the iframe to be https://www.youtube.com/embed/KqpHTFJO4mE?wmode=transparent&rel=0&autohide=1&enablejsapi=1&showinfo=0&start=0, which is properly blocked.

However the DOM element collapser uses the original src attribute to find out whether collapsing must take place, hence it fails to collapse the iframe which was blocked using redirected URL.

@ghost
Copy link

ghost commented Jan 3, 2016

@gorhill Another side effect of this would be that you could not allow it if you wished.

@gorhill
Copy link
Owner Author

gorhill commented Jan 3, 2016

you could not allow it if you wished

I don't understand why not. The logger shows everything, including redirections.

Repository owner locked and limited conversation to collaborators Jan 3, 2016
@gorhill
Copy link
Owner Author

gorhill commented Aug 5, 2020

Closing since I can't reproduce on the test case, the frame is properly collapsed.

@gorhill gorhill closed this as completed Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant