Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtime is not used from config #750

Closed
2 tasks done
keliramu opened this issue Dec 8, 2023 · 1 comment
Closed
2 tasks done

mtime is not used from config #750

keliramu opened this issue Dec 8, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@keliramu
Copy link
Contributor

keliramu commented Dec 8, 2023

What happened?

After recent changes, in your code you do not copy c.MTime over to info.MTime.
Also, you do not enforce mtime onto info.Content Files.

I would expect that mtime from config (or from env variable) to be enforce on all timestamps.

How can we reproduce this?

Code location: https://github.com/goreleaser/nfpm/blob/main/nfpm.go#L123
here you need to info.MTime = c.MTime

nfpm version

using Dec 7 commit: 7439013fb5dc9357e84aabb36823a21c1b97e8ba

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@keliramu keliramu added the bug Something isn't working label Dec 8, 2023
@caarlos0
Copy link
Member

caarlos0 commented Dec 8, 2023

hmm, seems like mergo is ignoring that field (and many others??)

will investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants