The sdist is missing tox.ini

[mtelka]

The sdist at PyPI is missing both tox.ini and requirements-tests.txt files. Please add them to sdist to make the downstream testing easier. Thanks.

[BoboTiG]

I would be glad to merge a PR :)

[mtelka]

Honestly, I do not know how this should be fixed because:

$ git clone https://github.com/gorakhargosh/watchdog.git
...
$ cd watchdog
$ git reset --hard v2.1.9
HEAD is now at 4cbf15c Release 2.1.9
$ python -m build --sdist --no-isolation
...
$ tar tvf dist/watchdog-2.1.9.tar.gz | egrep 'tox\.ini|requirements-tests\.txt' | wc -l
2
$

So maybe you should just upgrade your tools? I tested the above with Python 3.9.15 and build 0.9.0.

[BoboTiG]

The packaging is automatically handled by that job: https://github.com/gorakhargosh/watchdog/blob/master/.github/workflows/build-and-publish.yml

Maybe should we list missing files into https://github.com/gorakhargosh/watchdog/blob/master/MANIFEST.in?

[mtelka]

Or replace python setup.py sdist here by something more modern? I do not know what would fit better for you, but I think move out of setup.py is the way to go.

OTOH, watchdog is not converted to PEP 517 yet (pyproject.toml file is missing) so probably just MANIFEST.in update is simpler.

Thanks.