Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MakePicture methods always create new TargetPicture #57

Open
duysqubix opened this issue Oct 10, 2023 · 0 comments
Open

MakePicture methods always create new TargetPicture #57

duysqubix opened this issue Oct 10, 2023 · 0 comments

Comments

@duysqubix
Copy link
Contributor

Look at batch.go#L82 and canvas.go#L73
All MakePicture methods return new TargetPicture instances.
Also every Sprite caches a TargetPicture.
So, does that means, for 10k Sprites created from a single Picture, pixel creates 10k TargetPictures?
That sounds very inefficient!

Original issue: faiface/pixel#178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@duysqubix