Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change build artifacts name #1838

Merged
merged 1 commit into from
Apr 6, 2024
Merged

ci: change build artifacts name #1838

merged 1 commit into from
Apr 6, 2024

Conversation

cpunion
Copy link
Contributor

@cpunion cpunion commented Apr 3, 2024

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (244f458) to head (b6902f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1838   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          42       42           
  Lines       11440    11440           
=======================================
  Hits        10594    10594           
  Misses        684      684           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aofei aofei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xushiwei xushiwei merged commit 20d9b9a into goplus:main Apr 6, 2024
18 checks passed
aofei added a commit to aofei/.goplus.gop that referenced this pull request Apr 7, 2024
Following the changes introduced in goplus#1838, this commit updates Docker
image and manifest tags to align with the GoReleaser artifact naming
conventions. The changes are as follows:

- Image tags have been updated from "v1.2.3-i386" to "1.2.3-386", from
  "v1.2.3-x86_64" to "1.2.3-amd64", "v1.2.3-arm64" to "1.2.3-arm64".
- The version prefix "v" has been removed from the image manifest tags,
  changing "v1.2.3" to "1.2.3", "v1.2" to "1.2", and "v1" to "1".

Signed-off-by: Aofei Sheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants