cl/internal/typesutil: NewTypeAndValueForCallResult

goplus · Nov 15, 2023 · 645ce6b · 645ce6b
1 parent 5956193
commit 645ce6b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/cl/internal/typesutil/api.go b/cl/internal/typesutil/api.go
@@ -78,7 +78,7 @@ func NewTypeAndValueForVariable(typ types.Type) (ret types.TypeAndValue) {
 	return
 }
 
-func NewTypeAndValueForCall(typ types.Type) (ret types.TypeAndValue) {
+func NewTypeAndValueForCallResult(typ types.Type) (ret types.TypeAndValue) {
 	if typ == nil {
 		ret.Type = &types.Tuple{}
 		(*TypeAndValue)(unsafe.Pointer(&ret)).mode = novalue

diff --git a/cl/internal/typesutil/api_test.go b/cl/internal/typesutil/api_test.go
@@ -39,11 +39,11 @@ func TestTypeAndValue(t *testing.T) {
 	if !ret.Addressable() {
 		t.Fatal("NewTypeAndValueForVariable: not variable?")
 	}
-	ret = NewTypeAndValueForCall(tyInt)
+	ret = NewTypeAndValueForCallResult(tyInt)
 	if !ret.IsValue() {
 		t.Fatal("NewTypeAndValueForCall: not value?")
 	}
-	ret = NewTypeAndValueForCall(nil)
+	ret = NewTypeAndValueForCallResult(nil)
 	if !ret.IsVoid() {
 		t.Fatal("NewTypeAndValueForCall: not void?")
 	}
@@ -72,4 +72,8 @@ func TestTypeAndValue(t *testing.T) {
 	if !ret.IsNil() {
 		t.Fatal("NewTypeAndValueForObject: not nil?")
 	}
+	ret = NewTypeAndValueForObject(types.Universe.Lookup("len"))
+	if !ret.IsBuiltin() {
+		t.Fatal("NewTypeAndValueForObject: not builtin?")
+	}
 }