Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited timeout in python requests causes library to wait for requests forever. #22

Closed
dark-light-cz opened this issue Nov 14, 2023 · 3 comments · Fixed by #26
Closed
Assignees

Comments

@dark-light-cz
Copy link

In contrast with version 1 the actual version 2 is not providing timeout to to calls.

python Requests is used and in their dosumentation is written this:

Timeouts Most requests to external servers should have a timeout attached, in case the server is not responding in a timely manner. By default, requests do not time out unless a timeout value is set explicitly. Without a timeout, your code may hang for minutes or more.

In some cases - like network od DNS problems the library calls hangs forever.

I find this serious issue.

@geeshta geeshta self-assigned this Aug 26, 2024
@geeshta geeshta linked a pull request Aug 26, 2024 that will close this issue
@dark-light-cz
Copy link
Author

I would appreciate it if the timeout could be configured for each query. For example, I can't stop the client application for 300 seconds when trying to create a payment link.

@geeshta
Copy link
Contributor

geeshta commented Aug 27, 2024

@dark-light-cz You're right that it should be configurable. It will not be per request though, it will be configured when initializing the payments object.
It will be available on pypi with the next release after we merge some more stuff in.

@dark-light-cz
Copy link
Author

Thank you. It should be enough for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants