Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed_js returns invalid URL #16

Closed
martn opened this issue Jun 13, 2023 · 1 comment
Closed

Embed_js returns invalid URL #16

martn opened this issue Jun 13, 2023 · 1 comment

Comments

@martn
Copy link

martn commented Jun 13, 2023

Calling get_embedjs_url returns //gp-gw/js/embed.js which is a non-sense.

Looking to the code of the method:

@property
def get_embedjs_url(self) -> str:
    return self.gopay.base_url[-4] + "/gp-gw/js/embed.js"

It probably should be changed to:

@property
def get_embedjs_url(self) -> str:
    return self.gopay.base_url[:-4] + "/gp-gw/js/embed.js"
@geeshta geeshta mentioned this issue Jun 23, 2023
@gopayprovoz
Copy link
Contributor

Fixed by #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants