Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Note 5 user agent variant to Dpdb cache #185

Merged
merged 1 commit into from
Mar 15, 2017

Conversation

johnmaf
Copy link
Contributor

@johnmaf johnmaf commented Jan 6, 2017

We found that for one of our devices (a Samsung Note 5) the distortions were not being applied correctly, the reason being that the model number is "SM-N920W8" for Canadian devices.

We found that for one of our devices (a Samsung Note 5) the distortions were not being applied correctly, the reason being that the model number is "SM-N920W8" for Canadian devices.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@johnmaf
Copy link
Contributor Author

johnmaf commented Jan 6, 2017

I signed it!!

@googlebot
Copy link

CLAs look good, thanks!

@borismus
Copy link
Contributor

I'll accept this change for now, but keep in mind that DPDB is autogenerated from an internal database so at some point in the future, your change may be reverted.

@borismus borismus merged commit 86ff944 into immersive-web:master Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants