This repository has been archived by the owner on Nov 8, 2019. It is now read-only.
Fixed issue with InstantPreview trying to destroy already destroyed cameras #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've merged this into our system; thanks for the find and your contributions! :) |
|
Now released. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching between scenes causes the InstantPreview cameras to be destroyed. While checking whether the cameras should be removed it will try to destroy the already destoyed GameObject again. This causes the function to halt and the old cameras to remain in the list. This results in an error message every frame as shown below.
I added a null-check for the eye cameras. This way already destroyed objects will be skipped, but will still be removed from the list.