-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: updated Gradle version, plugins and libraries #212
Conversation
c5b3183
to
7923f0a
Compare
Since this removes the v3 beta, this will be considered a breaking change and require a major version bump. We are also fixing ambiguity about which dependency wins (transitive dependency on Maps SDK and Maps Utils in the build.gradle or explicitly added dependency recommended in the README) so promoting this from a |
Makes sense, arguably this is not a mere version or doc update anymore. |
This should fix #156 too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one nit!
app/build.gradle
Outdated
@@ -58,7 +58,7 @@ dependencies { | |||
implementation deps.androidx.coreKtx | |||
implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.4.1' | |||
implementation 'com.google.android.gms:play-services-maps:18.1.0' | |||
// implementation 'com.google.maps.android:maps-ktx:3.0.1' | |||
//implementation 'com.google.maps.android:maps-ktx:3.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there needs to be a space after the //
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly from a Gradle perspective, but I am not sure if the documentation script needs it. I have re-added it.
# [4.0.0](v3.4.0...v4.0.0) (2023-09-26) * fix!: updated Gradle version, plugins and libraries (#212) ([d622499](d622499)), closes [#212](#212) ### BREAKING CHANGES * remove v3 beta * chore: updated docs * chore: updated Gradle version, plugins and libraries * feat: updated Kotlin and dokka * chore: removed deprecated method
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This PR updates the AGP version, and that of several plugins and libraries. A small step for humankind, a big step for us.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #206 🦕
Fixes #192
Fixes #156