feat: Adding ability to publish to maven central #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
barbeau
approved these changes
Mar 4, 2020
| @@ -16,9 +16,17 @@ | |||
|
|
|||
| buildscript { | |||
| ext.versions = [ | |||
| 'android' : [ | |||
| "buildTools": "29.0.3", | |||
There was a problem hiding this comment.
Is there any way to pull these from the android-maps-utils Java library? Keeping these in sync will be a pain.
There was a problem hiding this comment.
Not that I can think of. As long as we keep the dependencies really light (i.e. maps-utils-ktx should only depend on AMU and kotlin-specific libs) keeping them in sync shouldn't be too much of a hassle.
That said, I'll remove appcompat as a dependency since it doesn't really need it. Eventually playServicesMaps and kotlinxCoroutines should be removed too and instead be a dependency on a maps-ktx module (i.e. KTX for Maps Core).
googlemaps-bot
pushed a commit
that referenced
this pull request
Apr 2, 2020
# 1.0.0 (2020-04-02) ### Bug Fixes * Add dependencies of maps-utils-ktx in pom. ([#14](#14)) ([d2f14e4](d2f14e4)) * next repositories inside publishing ([38e8dbc](38e8dbc)) * Use api instead of implementation. ([#10](#10)) ([ac40f46](ac40f46)) ### Features * Adding ability to publish to maven central ([#5](#5)) ([5cfa6b1](5cfa6b1)) * Adding KTX to Maps SDK ([#21](#21)) ([3313167](3313167)) * Adding PolyUtil extensions to List<LatLng> ([#16](#16)) ([d4cd6f5](d4cd6f5)) * Create maps-ktx module ([#20](#20)) ([597a70c](597a70c)) ### BREAKING CHANGES * Moved KTX for utils from com.google.maps.android.ktx to com.google.maps.android.ktx.utils to avoid package name conflicts with the new maps-ktx module. * refactor: move core extensions to separate package. * Using shared version. * Adjusting settings.gradle.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding gradle task to publish to maven central.
Relates to #3 🦕