Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create maps-ktx module #20

Merged
merged 5 commits into from
Mar 26, 2020
Merged

feat: Create maps-ktx module #20

merged 5 commits into from
Mar 26, 2020

Conversation

arriolac
Copy link
Contributor

Creating a new module, maps-ktx, where all Kotlin extensions for the Maps SDK will live.

BREAKING CHANGE: Moved Kotlin extensions for AMU from com.google.maps.android.ktx to com.google.maps.android.ktx.utils to avoid package name conflicts with the new module.

Relates #4

@arriolac arriolac added the semver: major Hint for users that this is an API breaking change. label Mar 25, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2020
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #20   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           9     7    -2     
  Lines          97    93    -4     
  Branches       18    17    -1     
====================================
+ Misses         97    93    -4
Impacted Files Coverage Δ
...java/com/google/maps/android/ktx/utils/Polyline.kt 0% <ø> (ø)
...om/google/maps/android/ktx/utils/geometry/Point.kt 0% <ø> (ø)
.../java/com/google/maps/android/ktx/utils/Polygon.kt 0% <ø> (ø)
.../google/maps/android/ktx/utils/heatmaps/Heatmap.kt 0% <ø> (ø)
...n/java/com/google/maps/android/ktx/utils/LatLng.kt 0% <ø> (ø)
.../java/com/google/maps/android/ktx/utils/kml/Kml.kt 0% <ø> (ø)
...m/google/maps/android/ktx/utils/geojson/GeoJson.kt 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b71b6f8...9573778. Read the comment docs.

BREAKING CHANGE: Moved KTX for utils from com.google.maps.android.ktx to
com.google.maps.android.ktx.utils to avoid package name conflicts with
the new maps-ktx module.
@arriolac arriolac merged commit 597a70c into master Mar 26, 2020
@arriolac arriolac deleted the chris/feat/4 branch March 26, 2020 17:41
googlemaps-bot pushed a commit that referenced this pull request Apr 2, 2020
# 1.0.0 (2020-04-02)

### Bug Fixes

* Add dependencies of maps-utils-ktx in pom. ([#14](#14)) ([d2f14e4](d2f14e4))
* next repositories inside publishing ([38e8dbc](38e8dbc))
* Use api instead of implementation. ([#10](#10)) ([ac40f46](ac40f46))

### Features

* Adding ability to publish to maven central ([#5](#5)) ([5cfa6b1](5cfa6b1))
* Adding KTX to Maps SDK ([#21](#21)) ([3313167](3313167))
* Adding PolyUtil extensions to List<LatLng> ([#16](#16)) ([d4cd6f5](d4cd6f5))
* Create maps-ktx module ([#20](#20)) ([597a70c](597a70c))

### BREAKING CHANGES

* Moved KTX for utils from com.google.maps.android.ktx to
com.google.maps.android.ktx.utils to avoid package name conflicts with
the new maps-ktx module.

* refactor: move core extensions to separate package.

* Using shared version.

* Adjusting settings.gradle.
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released semver: major Hint for users that this is an API breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants