Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing reason for cameraMoveStartedEvents() flow #169

Merged
merged 1 commit into from
Dec 1, 2021
Merged

fix: Add missing reason for cameraMoveStartedEvents() flow #169

merged 1 commit into from
Dec 1, 2021

Conversation

barbeau
Copy link
Contributor

@barbeau barbeau commented Dec 1, 2021 •
edited
Loading

Currently the reason parameter from onCameraMoveStarted (int reason) method in the GoogleMap.OnCameraMoveStartedListener isn't being passed through to the Flow:
https://developers.google.com/android/reference/com/google/android/gms/maps/GoogleMap.OnCameraMoveStartedListener

This PR passes the integer value through to the Flow.

Also add it to the demo app.

Closes #168

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #168 🦕

@barbeau barbeau requested a review from arriolac December 1, 2021 15:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2021
@barbeau barbeau mentioned this pull request Dec 1, 2021
Closed
arriolac
arriolac approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arriolac arriolac merged commit 2166001 into main Dec 1, 2021
@arriolac arriolac deleted the sean/camera-move-reason branch December 1, 2021 17:49
googlemaps-bot pushed a commit that referenced this pull request Dec 1, 2021
@semantic-release-bot
chore(release): 3.2.1 [skip ci]
2f25538 
## [3.2.1](v3.2.0...v3.2.1) (2021-12-01)

### Bug Fixes

* Add missing reason for cameraMoveStartedEvents() flow ([#169](#169)) ([2166001](2166001)), closes [#168](#168)
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arriolac arriolac arriolac approved these changes

Assignees

@arriolac arriolac

Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kotlin Flow: cameraMoveStartedEvents missing reason
3 participants
@barbeau @googlemaps-bot @arriolac