Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config::Config compatible with xDS manager #520

Closed
XAMPPRocky opened this issue Apr 19, 2022 · 0 comments · Fixed by #525
Closed

Make config::Config compatible with xDS manager #520

XAMPPRocky opened this issue Apr 19, 2022 · 0 comments · Fixed by #525
Assignees
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc area/xds Related to Envoy xDS kind/feature New feature or request

Comments

@XAMPPRocky
Copy link
Collaborator

Currently the xDS management server uses a slightly different file configuration than the quilkin client, because the Quilkin client requires some fields that aren't needed for the xDS manager. I think to simplify the code, that we re-use the same configuration type for both sides. To make this work we would just need to make a few changes to the schema to make it compatible with both agents. Mainly removing the dynamic/static distinction, and allowing all the current sub-properties to be optional in the root object. This would allow both client and server to read the same properties.

@XAMPPRocky XAMPPRocky added kind/feature New feature or request area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc area/xds Related to Envoy xDS labels Apr 19, 2022
@XAMPPRocky XAMPPRocky self-assigned this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Quilkin, e.g. cli interface, configuration, etc area/xds Related to Envoy xDS kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant