New fields in protobuf definitions #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akremsa
reviewed
Oct 27, 2020
Laremere
suggested changes
Oct 29, 2020
| @@ -81,6 +81,30 @@ message WatchAssignmentsResponse { | |||
| Assignment assignment = 1; | |||
| } | |||
|
|
|||
| message AcknowledgeBackfillRequest { | |||
There was a problem hiding this comment.
All of the new messages, RPC methods, and fields on existing messages need a beta warning. See the release tickets method on the backend for an example.
There was a problem hiding this comment.
Also please refer to this PR as an example:
https://github.com/googleforgames/open-match/pull/1273/files#diff-cb9fb1f207fd5b8c4ef3730293c848aa033832f8dd69ebb8f81d606af3cce387R208
aLekSer
reviewed
Oct 29, 2020
Laremere
approved these changes
Oct 29, 2020
Laremere
approved these changes
Oct 29, 2020
akremsa
approved these changes
Oct 30, 2020
aLekSer
approved these changes
Oct 30, 2020
syntxerror
added
area/productionization
area/feature
area/refinement
and removed
area/productionization
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
This PR adds new fields and structures in the Protobuf definitions. Also improves the Makefile display when running the available commands.
Which issue(s) this PR fixes:
This PR is part of the development of Backfill feature request.