Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocation policy needs to expose namespace of the targeted cluster #980

Closed
pooneh-m opened this issue Aug 5, 2019 · 3 comments
Closed
Labels
kind/bug These are bugs. kind/feature New features for Agones
Milestone

Comments

@pooneh-m
Copy link
Contributor

pooneh-m commented Aug 5, 2019

Allocation policy CRD is currently only exposing the LoadBalancer service endpoint for allocator service and not the namespace. This works fine if there is an allocator service for each namespace that game servers are deployed to #854.

However, currently, there is only one allocator service deployed to agones-system namespace and it is assumed that all clusters in multi-cluster scenario are using the same namespace name for deploying game servers.

The solution is to expose namespace in allocation policy.
[Bonus: This also enables A/B testing on the same cluster by deploying two version of game servers and setting weight on allocation policy to redirect a percentage of traffic to a namespace in the cluster.]

@pooneh-m pooneh-m added the kind/bug These are bugs. label Aug 5, 2019
@roberthbailey
Copy link
Member

Since this is still a v1alpha1 API group (indicating active development) I'm OK changing this between 0.12 and 1.0.

@markmandel
Copy link
Member

Can this now be closed?

https://help.github.com/en/articles/closing-issues-using-keywords might be useful going forward as well.

@pooneh-m
Copy link
Contributor Author

Thanks. Didn't know about the keyword. Next time :)

@markmandel markmandel added this to the 1.1.0 milestone Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

3 participants