Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Migrate Build Automation to k8s prow. #649

Closed
jeremyje opened this issue Mar 13, 2019 · 11 comments
Closed

Proposal: Migrate Build Automation to k8s prow. #649

jeremyje opened this issue Mar 13, 2019 · 11 comments
Assignees
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/tests Unit tests, e2e tests, anything to make sure things don't break kind/design Proposal discussing new features / fixes and how they should be implemented stale Pending closure unless there is a strong objection. wontfix Sorry, but we're not going to do that.

Comments

@jeremyje
Copy link
Contributor

jeremyje commented Mar 13, 2019

Proposal Document: https://docs.google.com/document/d/1BOhIKP3N9TjOEUSn28jZvLSTFWrE7DKg66LANNerLdg
Open Match Issue: googleforgames/open-match#107

@markmandel
Copy link
Member

markmandel commented Mar 13, 2019

What sort of things do we need? Prow seems very complicated.

@jeremyje
Copy link
Contributor Author

The plan is to use the k8s prow so we are not managing the instance. We mainly need to provide the config.yaml and plugins.yaml files.

In the Agones case it seems like it'll remove the need to have agones-bot.

@jeremyje jeremyje changed the title Migrate Build Automation to k8s prow. Proposal: Migrate Build Automation to k8s prow. Mar 13, 2019
@markmandel markmandel added kind/design Proposal discussing new features / fixes and how they should be implemented area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Mar 13, 2019
@markmandel
Copy link
Member

Was thinking about this today - would it be useful to have a list of all the custom CI/build pipeline things that currently exist?

@roberthbailey
Copy link
Member

Yes, having a list would be very helpful.

@roberthbailey
Copy link
Member

@Kuqd - I saw your (old) note in Slack about cloud build e2e vs. prow and thought we should re-open the discussion. I think it'd be a great topic for the community meeting scheduled on the 25th. Could you take another pass over the document before then and add some comments?

@roberthbailey
Copy link
Member

@heartrobotninja - did you have any other comments you wanted to leave on the doc? As I mentioned in the above comment, I think this would be a great topic to discuss at the next community meeting (on the 25th of this month).

@cyriltovena
Copy link
Collaborator

Will do ! Thank you

@roberthbailey
Copy link
Member

roberthbailey commented Apr 25, 2019

This topic was discussed at the community meeting today (notes) and the consensus is that we should move to prow.

Since not everyone who wants to give input may have had a chance to attend the meeting, we are going to initiate a lazy consensus process: we will start moving to prow unless anyone raises objections before May 1st (next Wednesday).

@roberthbailey
Copy link
Member

/assign

@markmandel
Copy link
Member

@roberthbailey do we still want to migrate? Seems like Cloud Build is still fine?

If anything, we could move the things we use prow for to Github Actions, and remove some of the noise in our PRs.

@roberthbailey
Copy link
Member

Cloud Build has definitely been working for what we need. At this point I'm not seeing a strong reason to change things around.

I don't know enough about Github Actions to know whether that would be an improvement, but if so we should open a separate issue to track it.

I'm going to close this issue as obsolete.

@markmandel markmandel added the wontfix Sorry, but we're not going to do that. label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/tests Unit tests, e2e tests, anything to make sure things don't break kind/design Proposal discussing new features / fixes and how they should be implemented stale Pending closure unless there is a strong objection. wontfix Sorry, but we're not going to do that.
Projects
None yet
Development

No branches or pull requests

4 participants